-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): directory sync fix + test bed rewrites #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't like the word 'only' in tests lol, makes searching for .only() tests kinda annoying! Also using console.info so our console mocking doesn't interfere with our local debugging. ESLint config on this to come!
We're only using this mock in a single place!
13 tasks
kanadgupta
commented
Jan 4, 2022
@@ -6,7 +6,7 @@ exports.generatePrompts = (versionList, selectOnly = false) => [ | |||
{ | |||
type: 'select', | |||
name: 'option', | |||
message: 'Would you like to use an existing version or create a new one to associate with your OAS file?', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were previously using this OAS-specific language in a bunch of places (version commands, docs commands, etc.) 😬
erunion
approved these changes
Jan 4, 2022
Co-Authored-By: Jon Ursenbach <jon@ursenba.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Another follow-up to #410. This time we're focusing on our
docs
commands:0
) if the docs syncing failed for any reason. Now a failure rejects the promise and returns a failure exit code (1
).1
) and returns an error message containing the problematic file path.console.log
instances withconsole.info
.🧬 QA & Testing
See tests.